Skip to content

Read the CI Go version from go.mod, drop a stale backlog item - #93

Merged
umputun merged 2 commits into
masterfrom
fix/ci-go-version-from-gomod
Oct 26, 2026
Merged

umputun merged 2 commits into
masterfrom
fix/ci-go-version-from-gomod

Conversation

@paskal

@paskal paskal commented Oct 11, 2026

Copy link
Copy Markdown
Member

CI reads its Go version from go.mod, removing the separate Go 1.25 selector that blocks dependency updates requiring Go 1.26. The major and minor version come from the go directive and setup-go resolves the newest patch of that line, so the workflow follows the directive without pinning a patch of its own.

The obsolete SSRF backlog item is removed because the implementation it concerns, extractor/safedial.go, is absent from the remaining branches.

Verified with actionlint, which reports the same findings here as on master. The selector is exercised by #91, which requires Go 1.26 and fails on the current workflow.

The fixed Go 1.25 selector cannot satisfy newer module requirements.
Derive the major and minor version from the go directive and let setup-go
pick the newest patch, so the two stay in step without pinning a patch.
The item concerns extractor/safedial.go, which is absent from the
remaining branches.

@umputun umputun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@umputun
umputun merged commit ff2702b into master Oct 26, 2026
2 checks passed
@umputun
umputun deleted the fix/ci-go-version-from-gomod branch October 26, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants